fix(discord): support least-privilege bot permissions without Administrator#24
Merged
fix(discord): support least-privilege bot permissions without Administrator#24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the need to run the bot with
Administratorand makes the Discord channel setup flow more reliable when using a minimal permission set.The main issue was that the bot could create categories/channels and send messages, but it failed when applying channel/category permission overwrites. This PR updates the setup flow so the bot can safely work with explicit Discord permissions instead of relying on
Administrator.What Changed
awaitandlockPermissions: falseto avoid overwrite conflicts during setup.Why
The previous setup could fail in partially configured guilds because:
With this change, the bot now works correctly with a proper minimal permission set and no longer requires
Administrator.Required Bot Scopes
botapplications.commandsRequired Bot Permissions
These permissions are required for normal full operation with the current codebase:
View ChannelsManage ChannelsManage RolesSend MessagesEmbed LinksAttach FilesRead Message HistoryManage MessagesOptional Bot Permissions
These are only needed if the related features are used:
Mention EveryoneRequired for
@everyone/@herenotification features.Change NicknameRequired if the bot should set/update its server nickname on startup.
ConnectRequired for voice channel features.
SpeakRequired for voice playback features.
Send TTS MessagesRequired for Discord TTS output.
Not Required
The bot does not require:
AdministratorKick MembersBan MembersManage WebhooksManage GuildResult
The bot can now be installed with a least-privilege permission model while still supporting channel creation, overwrite management, embeds, attachments, and normal setup automation.